github.com/spf13/pflag v1.0.10: Show that a wrapped ErrHelp error is no longer treated as help in the parser's ExitOnError path after this patch boundary.

`search_known_solution` returned `miss` for this boundary, so no cached sample existed for this trap.

Wrong-version behavior signal: pre-change versions treat wrapped `ErrHelp` as help (exit 0), while this resolved version returns exit 2 with a parse error.

{"case":{"believed":"A wrapped ErrHelp value from a flag setter should still be treated as a help request and exit with code 0.","caseId":"case:sha256:ef20761574f47d132481101ff50cafa95c1f6e6625e3d905fda0a3d21d041eb8","contract":["With ErrorHandling=ExitOnError, FlagSet.Parse returns a wrapped ErrHelp via Set() and exits with status 2, not 0.","With ErrorHandling=ExitOnError, FlagSet.Parse returns an unwrapped ErrHelp via Set() and exits with status 0."],"goal":"Show that a wrapped ErrHelp error is no longer treated as help in the parser's ExitOnError path after this patch boundary.","kind":"HOW","packages":["pkg:golang/github.com/spf13/pflag@v1.0.10"],"schemaVersion":1,"symbols":["FlagSet.Parse"]},"contractCommand":["go","test","./..."],"environment":{"arch":"x64","ecosystem":"golang","language":"go","os":"linux","packageManager":"go","runtime":"go","schemaVersion":1},"license":"MIT-0","packages":["pkg:golang/github.com/spf13/pflag@v1.0.10"],"schemaVersion":1,"symbols":["FlagSet.Parse"],"verifierAdapter":"golang@1"}

module example.org/pflag-trap

go 1.13

require github.com/spf13/pflag v1.0.10

github.com/spf13/pflag v1.0.10 h1:4EBh2KAYBwaONj6b2Ye1GiHfwjqyROoF4RwYO+vPwFk=
github.com/spf13/pflag v1.0.10/go.mod h1:McXfInJRrz4CZXVZOBLb0bTZqETkiAhM9Iw0y3An2Bg=

package main

import (
	"errors"
	"fmt"
	"os"
	"os/exec"
	"strings"
	"testing"

	pflag "github.com/spf13/pflag"
)

type wrappedErrHelpValue struct{}

func (wrappedErrHelpValue) String() string        { return "" }
func (wrappedErrHelpValue) Type() string          { return "wrappedErrHelp" }
func (wrappedErrHelpValue) Set(_ string) error     { return fmt.Errorf("wrapped err: %w", pflag.ErrHelp) }

func TestWrappedErrHelpStillExitsWithCode2(t *testing.T) {
	cmd := exec.Command(os.Args[0], "-test.run=TestWrappedErrHelpProcess", "--", "child")
	cmd.Env = append(os.Environ(), "PFLAG_WRAPPED_HELPER=1")

	output, err := cmd.CombinedOutput()
	if err == nil {
		t.Fatalf("expected wrapped ErrHelp to exit non-zero, output: %s", string(output))
	}

	var exitErr *exec.ExitError
	if !errors.As(err, &exitErr) {
		t.Fatalf("expected *exec.ExitError, got: %v", err)
	}
	if exitCode := exitErr.ExitCode(); exitCode != 2 {
		t.Fatalf("expected exit code 2 for wrapped ErrHelp, got: %d", exitCode)
	}
	if !strings.Contains(string(output), "wrapped err:") {
		t.Fatalf("expected parse error output for wrapped ErrHelp, got: %s", string(output))
	}
}

func TestWrappedErrHelpProcess(t *testing.T) {
	if os.Getenv("PFLAG_WRAPPED_HELPER") != "1" {
		return
	}

	flags := pflag.NewFlagSet("wrapped", pflag.ExitOnError)
	flags.Var(wrappedErrHelpValue{}, "help-me", "wraps ErrHelp")
	flags.Parse([]string{"--help-me=1"})
}

func TestBuiltinHelpStillExitsWithCode0(t *testing.T) {
	cmd := exec.Command(os.Args[0], "-test.run=TestBuiltinHelpProcess", "--", "child")
	cmd.Env = append(os.Environ(), "PFLAG_DIRECT_HELPER=1")

	output, err := cmd.CombinedOutput()
	if err != nil {
		t.Fatalf("expected built-in help to exit 0, got: %v output: %s", err, string(output))
	}
	if !strings.Contains(string(output), "Usage of") {
		t.Fatalf("expected usage output, got: %s", string(output))
	}
}

func TestBuiltinHelpProcess(t *testing.T) {
	if os.Getenv("PFLAG_DIRECT_HELPER") != "1" {
		return
	}

	flags := pflag.NewFlagSet("direct", pflag.ExitOnError)
	flags.Parse([]string{"--help"})
	os.Exit(0)
}